Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: remove pylint #4817

Merged
merged 6 commits into from
Jun 7, 2024
Merged

style: remove pylint #4817

merged 6 commits into from
Jun 7, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented May 21, 2024 •
edited
Loading

Pylint is pretty much entirely replaced with ruff at this point.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@lengau
style: remove pylint
ca3d873 
Pylint is pretty much entirely replaced with ruff at this point.
@lengau lengau requested review from mr-cal and tigarmo May 21, 2024 21:55
@lengau lengau marked this pull request as ready for review May 21, 2024 21:55
mr-cal
mr-cal approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a few rule names to the noqas as suggestions.

snapcraft/commands/status.py Outdated Show resolved Hide resolved
snapcraft/commands/status.py Outdated Show resolved Hide resolved
snapcraft/elf/_elf_file.py Outdated Show resolved Hide resolved
snapcraft/parts/lifecycle.py Outdated Show resolved Hide resolved
snapcraft/parts/grammar.py Outdated Show resolved Hide resolved
tests/unit/parts/test_grammar.py Outdated Show resolved Hide resolved
lengau and others added 2 commits May 24, 2024 10:31
@lengau @mr-cal
fix: apply suggestions from code review
4e9ae02 
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
@lengau
Merge branch 'main' into less-pylint
7f48a81
@mr-cal mr-cal merged commit a9badaa into main Jun 7, 2024
9 of 10 checks passed
@mr-cal mr-cal deleted the less-pylint branch June 7, 2024 17:49
@mr-cal mr-cal mentioned this pull request Jun 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@tigarmo tigarmo tigarmo approved these changes

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lengau @cmatsuoka @tigarmo @mr-cal